Conversation
|
I'll have a look soon. You will see from the CI runs above, that installing pandas from source still requires versioneer, so please add it back to that env (or add a line to the script part of the workflow to install it just before building pandas). |
Helo Martin, My analysis is the following:
I may be wrong but the solution I would propose is:
My questions are probably very naïve, I have a limited understanding of this. |
|
Hm, you analysis seems spot on. |
|
only if we run with py313, no?
We already have incompatibilities I haven't been able to spare the time to fix ( |
|
By the way: Cython 3.1 (alpha) is available now by using the |
Dear Martin, I quickly checked pandas build own workflow, and I have no real clue what is going on. |
|
There will be nothing "free threading" related in py3.10 - it will need to be 3.13. Even then, I don't know if it requires specifically the free-threaded build. |
I agree with you, it should not be that complex. It would be surprising new pandas is breaking support for previous python versions and cython versions. For this PR, I would propose to leave it as it is. |
Fix version handling with setuptools_scm
PR to solves issue 950, where fastparquet version number is not correctly generated when CI is runned from a fork.
This PR finalilzes versioneer replacement with setuptools_scm for version management. The changes are focused on making the version system work properly.
Disclaimer
I have no experience in version system management, only in analyzing failing runs.
I conducted the analysis with help of Cursor AI + Claude 3.7 Sonnet, and the AI agent made the changes.
I double-checked them to prevent any change that would seem to me out of place.
Only these remaining changes appear to me the ones required to solve the problem.
Changes
Remove versioneer:
Configure setuptools_scm properly:
use_scm_version=Trueto defer to pyproject.toml configImprove tag handling in CI:
These changes ensure that version information is correctly generated during builds, especially in CI environments where git tags might not be fully available.
Testing
The changes have been tested in CI which now runs successfully.